Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8179880: Refactor javax/security shell tests to plain java tests #429

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 27, 2021

I downport this for parity with 11.0.13-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8179880: Refactor javax/security shell tests to plain java tests

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/429/head:pull/429
$ git checkout pull/429

Update a local copy of the PR:
$ git checkout pull/429
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/429/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 429

View PR using the GUI difftool:
$ git pr show -t 429

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/429.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the title 7f55dc15769bbab59024aa49671bced633de40ed 7f55dc15769bbab59024aa49671bced633de40ed blubb Sep 28, 2021
@GoeLin GoeLin changed the title 7f55dc15769bbab59024aa49671bced633de40ed blubb 7f55dc15769bbab59024aa49671bced633de40ed Sep 28, 2021
@GoeLin GoeLin changed the title 7f55dc15769bbab59024aa49671bced633de40ed Backport 7f55dc15769bbab59024aa49671bced633de40ed Sep 28, 2021
@openjdk openjdk bot changed the title Backport 7f55dc15769bbab59024aa49671bced633de40ed 8179880: Refactor javax/security shell tests to plain java tests Sep 28, 2021
@openjdk
Copy link

openjdk bot commented Sep 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 28, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2021

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8179880: Refactor javax/security shell tests to plain java tests

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • cb4e287: 8255227: java/net/httpclient/FlowAdapterPublisherTest.java intermittently failing with TestServer: start exception: java.io.IOException: Invalid preface
  • 654ad1c: 8266949: Check possibility to disable OperationTimedOut on Unix
  • d896cda: 8248341: ProblemList java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java
  • 3dc942c: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception
  • c3bdce8: 8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails
  • c9855f1: 8233564: [TESTBUG] MouseComboBoxTest.java is failing
  • 8d78072: 8258855: Two tests sun/security/krb5/auto/ReplayCacheTestProc.java and ReplayCacheTestProcWithMD5.java failed on OL8.3
  • d655d00: 8265019: Update tests for additional TestNG test permissions
  • 9121f55: 8253866: Security Libs Terminology Refresh
  • d3a8a9e: 8253497: Core Libs Terminology Refresh
  • ... and 5 more: https://git.openjdk.java.net/jdk11u-dev/compare/98f17dfa62863c1255b69594f8ad22e13ed0d5e7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 28, 2021
@GoeLin
Copy link
Member Author

GoeLin commented Sep 30, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 30, 2021

Going to push as commit 2baf9ea.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 11659aa: 8274056: JavaAccessibilityUtilities leaks JNI objects
  • b4b50cb: Merge
  • c9c7288: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  • ba3cc92: 8213707: [TEST] vmTestbase/nsk/stress/except/except011.java failed due to wrong class name
  • cb4e287: 8255227: java/net/httpclient/FlowAdapterPublisherTest.java intermittently failing with TestServer: start exception: java.io.IOException: Invalid preface
  • 654ad1c: 8266949: Check possibility to disable OperationTimedOut on Unix
  • d896cda: 8248341: ProblemList java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java
  • 3dc942c: 8047218: [TEST_BUG] java/awt/FullScreen/AltTabCrashTest/AltTabCrashTest.java fails with exception
  • c3bdce8: 8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails
  • c9855f1: 8233564: [TESTBUG] MouseComboBoxTest.java is failing
  • ... and 9 more: https://git.openjdk.java.net/jdk11u-dev/compare/98f17dfa62863c1255b69594f8ad22e13ed0d5e7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 30, 2021
@openjdk
Copy link

openjdk bot commented Sep 30, 2021

@GoeLin Pushed as commit 2baf9ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8179880 branch September 30, 2021 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants