Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8196096: javax/swing/JPopupMenu/6580930/bug6580930.java fails #431

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 28, 2021

Backport of JDK-8196096: javax/swing/JPopupMenu/6580930/bug6580930.java fails

Needed some manual resolving in the test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8196096: javax/swing/JPopupMenu/6580930/bug6580930.java fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/431/head:pull/431
$ git checkout pull/431

Update a local copy of the PR:
$ git checkout pull/431
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/431/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 431

View PR using the GUI difftool:
$ git pr show -t 431

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/431.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 28, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot changed the title Backport b5b24b904a68432153e8fa5c10cab5c27e871722 8196096: javax/swing/JPopupMenu/6580930/bug6580930.java fails Sep 28, 2021
@openjdk openjdk bot added backport rfr labels Sep 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 28, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8196096: javax/swing/JPopupMenu/6580930/bug6580930.java fails

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • c3bdce8: 8163086: java/awt/Window/TranslucentJAppletTest/TranslucentJAppletTest.java fails
  • c9855f1: 8233564: [TESTBUG] MouseComboBoxTest.java is failing
  • 8d78072: 8258855: Two tests sun/security/krb5/auto/ReplayCacheTestProc.java and ReplayCacheTestProcWithMD5.java failed on OL8.3
  • d655d00: 8265019: Update tests for additional TestNG test permissions
  • 9121f55: 8253866: Security Libs Terminology Refresh
  • d3a8a9e: 8253497: Core Libs Terminology Refresh
  • b433235: 8081652: [TESTBUG] java/lang/management/ThreadMXBean/ThreadMXBeanStateTest.java timed out intermittently
  • 1476158: 8216417: cleanup of IPv6 scope-id handling
  • d234b6d: 8230019: [REDO] compiler/types/correctness/* tests fail with "assert(recv == __null || recv->is_klass()) failed: wrong type"
  • d7ac85a: 8244292: Headful clients failing with --illegal-access=deny

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 28, 2021
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Sep 30, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

Going to push as commit b9f0143.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 05cb444: 8180571: Refactor sun/security/pkcs11 shell tests to plain java tests and fix failures
  • dce04a2: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions
  • 89d4ef2: 8078219: Verify lack of @test tag in files in java/net test directory
  • e5b1dbf: 8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99
  • f139171: 8215889: assert(!_unloading) failed: This oop is not available to unloading class loader data with ZGC
  • 97859e8: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • 245ccb2: 8269768: JFR Terminology Refresh
  • 2baf9ea: 8179880: Refactor javax/security shell tests to plain java tests
  • 11659aa: 8274056: JavaAccessibilityUtilities leaks JNI objects
  • b4b50cb: Merge
  • ... and 16 more: https://git.openjdk.java.net/jdk11u-dev/compare/45906dc1e01c18db30ebe761b022805053cad536...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@RealCLanger Pushed as commit b9f0143.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-b5b24b90 branch Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants