8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99

[TheRealMDoerr]

Backport of JDK-8231501. Applies almost cleanly. Only one comment change had to get integrated manually due to unrelated context change.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99

Reviewers

• Paul Hohensee (@phohensee - Reviewer) ⚠️ Review applies to 69b245b

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/435/head:pull/435
$ git checkout pull/435

Update a local copy of the PR:
$ git checkout pull/435
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/435/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 435

View PR using the GUI difftool:
$ git pr show -t 435

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/435.diff

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into pr/434 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue and summary from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (3d6fc3ca)
• 01: Full - Incremental (69b245b4)
• 00: Full (69b245b4)

[phohensee]

Unsure whether this needs review, but if it does, lgtm.

[openjdk-notifier]

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout 8215889_ciMethodData
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*):  fatal error: unexpected tag 99

Snapshot MDO extra trap and argument data only after it is prepared.

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheRealMDoerr]

/integrate

[openjdk]

Going to push as commit e5b1dbf.

[openjdk]

@TheRealMDoerr Pushed as commit e5b1dbf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.