Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass #436

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 28, 2021

I downport this for parity with 11.0.13-oracle.

Files p/Foo.java and q/Bar.java are not in 11. They were added by
8266269: Lookup::accessClass fails with IAE when accessing an arrayCl...
This is not in 11, and was not downported by Oracle. It has a CSR and changes
exceptions, so probably Oracle had a good reason not to bring it to 11.
Because 8266269 is missing though, I had to adapt the change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/436/head:pull/436
$ git checkout pull/436

Update a local copy of the PR:
$ git checkout pull/436
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/436/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 436

View PR using the GUI difftool:
$ git pr show -t 436

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/436.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 28, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 56240690f62f9048a45a53525efccffdec235a8d 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass Sep 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Sep 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 28, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • e5b1dbf: 8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99
  • f139171: 8215889: assert(!_unloading) failed: This oop is not available to unloading class loader data with ZGC
  • 97859e8: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • 245ccb2: 8269768: JFR Terminology Refresh
  • 2baf9ea: 8179880: Refactor javax/security shell tests to plain java tests
  • 11659aa: 8274056: JavaAccessibilityUtilities leaks JNI objects
  • b4b50cb: Merge
  • c9c7288: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  • ba3cc92: 8213707: [TEST] vmTestbase/nsk/stress/except/except011.java failed due to wrong class name
  • cb4e287: 8255227: java/net/httpclient/FlowAdapterPublisherTest.java intermittently failing with TestServer: start exception: java.io.IOException: Invalid preface
  • ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/c3bdce8f5935339c701235ab0dbed2d2540eafbf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 30, 2021
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Sep 30, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

Going to push as commit b79e707.
Since your change was applied there have been 17 commits pushed to the master branch:

  • b9f0143: 8196096: javax/swing/JPopupMenu/6580930/bug6580930.java fails
  • 05cb444: 8180571: Refactor sun/security/pkcs11 shell tests to plain java tests and fix failures
  • dce04a2: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions
  • 89d4ef2: 8078219: Verify lack of @test tag in files in java/net test directory
  • e5b1dbf: 8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99
  • f139171: 8215889: assert(!_unloading) failed: This oop is not available to unloading class loader data with ZGC
  • 97859e8: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • 245ccb2: 8269768: JFR Terminology Refresh
  • 2baf9ea: 8179880: Refactor javax/security shell tests to plain java tests
  • 11659aa: 8274056: JavaAccessibilityUtilities leaks JNI objects
  • ... and 7 more: https://git.openjdk.java.net/jdk11u-dev/compare/c3bdce8f5935339c701235ab0dbed2d2540eafbf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 30, 2021
@openjdk openjdk bot added integrated and removed ready labels Sep 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@GoeLin Pushed as commit b79e707.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 30, 2021
@GoeLin GoeLin deleted the goetz_backport_8269426 branch Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants