Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269768: JFR Terminology Refresh #438

Closed
wants to merge 1 commit into from

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 28, 2021

I downport this for parity with 11.0.13-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/438/head:pull/438
$ git checkout pull/438

Update a local copy of the PR:
$ git checkout pull/438
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/438/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 438

View PR using the GUI difftool:
$ git pr show -t 438

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/438.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 28, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 1c18f914386a7543a95984294c6d61004c0a7176 8269768: JFR Terminology Refresh Sep 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8269768: JFR Terminology Refresh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 28, 2021

Webrevs

Loading

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Sep 30, 2021

/integrate

Loading

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Sep 30, 2021

Pre-submit test failure unrelated to this comment change.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

Going to push as commit 245ccb2.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 2baf9ea: 8179880: Refactor javax/security shell tests to plain java tests
  • 11659aa: 8274056: JavaAccessibilityUtilities leaks JNI objects
  • b4b50cb: Merge
  • c9c7288: 8269850: Most JDK releases report macOS version 12 as 10.16 instead of 12.0
  • ba3cc92: 8213707: [TEST] vmTestbase/nsk/stress/except/except011.java failed due to wrong class name

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Sep 30, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@GoeLin Pushed as commit 245ccb2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant