Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223138: Small clean-up in loop-tree support. #445

Closed
wants to merge 1 commit into from

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 29, 2021

I downport this for parity with 11.0.13-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/445/head:pull/445
$ git checkout pull/445

Update a local copy of the PR:
$ git checkout pull/445
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 445

View PR using the GUI difftool:
$ git pr show -t 445

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/445.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 29, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 205085d8d5143c0d8517bcfc021457492a329c18 8223138: Small clean-up in loop-tree support. Sep 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

This backport pull request has now been updated with issue and summary from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8223138: Small clean-up in loop-tree support.

Rename predicate 'is_inner()' to 'is_innermost()' to be accurate. Added 'is_root()' predicate for root parent test in loop-tree. Changed definition of 'is_loop()' to always lazy-read the tail, since it should never be NULL. Cleanup of 'tail()' definition.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 29, 2021

Webrevs

Loading

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Sep 30, 2021

gc/stress/gcold/TestGCOldWithCMS.java failed in Pre-submit tests on x86
It crashed in gc/stress/gcold/TestGCOldWithCMS.java

Loading

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Oct 4, 2021

Failure probably JDK-8272195, thus unrelated to my change.

Loading

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Oct 4, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

Going to push as commit d86cf10.
Since your change was applied there have been 24 commits pushed to the master branch:

  • 3b88f74: 8187649: ArrayIndexOutOfBoundsException in java.util.JapaneseImperialCalendar
  • 6285123: 8268555: Update HttpClient tests that use ITestContext to jtreg 6+1
  • 89ee611: 8223923: C2: Missing interference with mismatched unsafe accesses
  • f12af7e: 8266182: Automate manual steps listed in the test jdk/sun/security/pkcs12/ParamsTest.java
  • 28dec4f: 8223139: Rename mandatory policy-do routines.
  • e1cbfa5: 8248187: [TESTBUG] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails with String is not properly drawn
  • 6a784d2: 8143021: [TEST_BUG] Test javax/swing/JColorChooser/Test6541987.java fails
  • 09ad2c0: 8256152: tests fail because of ambiguous method resolution
  • 2990ff0: 8211171: move JarUtils to top-level testlibrary
  • f7a75de: 8265524: Upgrading JSZip from v3.2.2 to v3.6.0
  • ... and 14 more: https://git.openjdk.java.net/jdk11u-dev/compare/11659aa62fa94e001655433e045b950c232208c1...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

@GoeLin Pushed as commit d86cf10.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant