Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8234823: java/net/Socket/Timeouts.java testcase testTimedConnect2() fails on Windows 10 #447

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 29, 2021

Hi all,

this pull request contains a backport of JDK-8234823 from the openjdk/jdk repository.

The commit being backported was authored by Michael McMahon on 3 Dec 2019 and was reviewed by Alan Bateman.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8234823: java/net/Socket/Timeouts.java testcase testTimedConnect2() fails on Windows 10

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/447/head:pull/447
$ git checkout pull/447

Update a local copy of the PR:
$ git checkout pull/447
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/447/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 447

View PR using the GUI difftool:
$ git pr show -t 447

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/447.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 29, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a2fad13ce29e6de9b9dead7da49de7c0544d32c6 8234823: java/net/Socket/Timeouts.java testcase testTimedConnect2() fails on Windows 10 Sep 29, 2021
@openjdk
Copy link

openjdk bot commented Sep 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 29, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8234823: java/net/Socket/Timeouts.java testcase testTimedConnect2() fails on Windows 10

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 29, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 29, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 1, 2021

Going to push as commit a6ee356.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 23c3845: 8229935: [TEST_BUG]: bug8132119.java inconsistently positions text
  • ed98060: 8223137: Rename predicate 'do_unroll_only()' to 'is_unroll_only()'.
  • b79e707: 8269426: Rename test/jdk/java/lang/invoke/t8150782 to accessClassAndFindClass
  • b9f0143: 8196096: javax/swing/JPopupMenu/6580930/bug6580930.java fails
  • 05cb444: 8180571: Refactor sun/security/pkcs11 shell tests to plain java tests and fix failures
  • dce04a2: 8272342: [TEST_BUG] java/awt/print/PrinterJob/PageDialogMarginTest.java catches all exceptions
  • 89d4ef2: 8078219: Verify lack of @test tag in files in java/net test directory
  • e5b1dbf: 8231501: VM crash in MethodData::clean_extra_data(CleanExtraDataClosure*): fatal error: unexpected tag 99
  • f139171: 8215889: assert(!_unloading) failed: This oop is not available to unloading class loader data with ZGC
  • 97859e8: 8268093: Manual Testcase: "sun/security/krb5/config/native/TestDynamicStore.java" Fails with NPE
  • ... and 2 more: https://git.openjdk.java.net/jdk11u-dev/compare/11659aa62fa94e001655433e045b950c232208c1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 1, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 1, 2021
@openjdk
Copy link

openjdk bot commented Oct 1, 2021

@RealCLanger Pushed as commit a6ee356.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant