-
Notifications
You must be signed in to change notification settings - Fork 251
8268555: Update HttpClient tests that use ITestContext to jtreg 6+1 #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed description of how you resolved it. LGTM.
|
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 18 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit 6285123.
Your commit was automatically rebased without conflicts. |
I downport this for parity with 11.0.13-oracle.
Response204V2Test.java: resolve imports due to context.
ShortResponseBody.java: resolve copyright and imports.
Change to test/jdk/java/net/httpclient/AggregateRequestBodyTest.java omitted.
The test is not in 11, it only came with "8252374 Add a new factory
method to concatenate..." in 16.
Change to test/jdk/java/net/httpclient/CancelRequestTest.java omitted.
The test is not in 11, it only came with "8245462: HttpClient send throws InterruptedException when interrupted but does not cancel request" in 16.
Change to test/jdk/java/net/httpclient/ISO_8859_1_Test.java b/test/jdk/java/net/httpclient/ISO_8859_1_Test.java omitted.
The test is not in 11, it only came with "8255244 HttpClient: Response headers contain incorrectly encoded Unicode characters" in 16.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/448/head:pull/448$ git checkout pull/448Update a local copy of the PR:
$ git checkout pull/448$ git pull https://git.openjdk.java.net/jdk11u-dev pull/448/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 448View PR using the GUI difftool:
$ git pr show -t 448Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/448.diff