Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223139: Rename mandatory policy-do routines. #449

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 30, 2021

I downport this for parity with 11.0.14-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/449/head:pull/449
$ git checkout pull/449

Update a local copy of the PR:
$ git checkout pull/449
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/449/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 449

View PR using the GUI difftool:
$ git pr show -t 449

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/449.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 30, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ceef0f69dcde777e7fdb6ccccb576ab44def716b 8223139: Rename mandatory policy-do routines. Sep 30, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 30, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8223139: Rename mandatory policy-do routines.

Rename 'policy_do_remove_empty_loop' to 'do_remove_empty_loop', 'policy_do_one_iteration_loop' to 'do_one_iteration_loop'.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 30, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 30, 2021

Webrevs

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Oct 2, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

Going to push as commit 28dec4f.
Since your change was applied there have been 7 commits pushed to the master branch:

  • e1cbfa5: 8248187: [TESTBUG] javax/swing/plaf/basic/BasicGraphicsUtils/8132119/bug8132119.java fails with String is not properly drawn
  • 6a784d2: 8143021: [TEST_BUG] Test javax/swing/JColorChooser/Test6541987.java fails
  • 09ad2c0: 8256152: tests fail because of ambiguous method resolution
  • 2990ff0: 8211171: move JarUtils to top-level testlibrary
  • f7a75de: 8265524: Upgrading JSZip from v3.2.2 to v3.6.0
  • 9f8c13c: 8233569: [TESTBUG] JTextComponent test bug6361367.java fails on macos
  • a6ee356: 8234823: java/net/Socket/Timeouts.java testcase testTimedConnect2() fails on Windows 10

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 4, 2021

@GoeLin Pushed as commit 28dec4f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant