Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY" #465

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 5, 2021

I backport this for parity with 11.0.14-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/465/head:pull/465
$ git checkout pull/465

Update a local copy of the PR:
$ git checkout pull/465
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/465/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 465

View PR using the GUI difftool:
$ git pr show -t 465

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/465.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 5, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 566d77a2ae4ee8830c989ea03f7bc6923df061cd 8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY" Oct 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Oct 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 5, 2021

Webrevs

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Oct 6, 2021

Pre-submit test failure on x86 is
/gc/metaspace/TestMetaspacePerfCounters_id1.jtr
Execution failed: `main' threw exception: java.lang.RuntimeException: assertGreaterThanOrEqual: expected 5529600 >= 5686144

This is sure unrelated to this test fix.

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Oct 6, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

Going to push as commit 7f5569c.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 620726e: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed"
  • 76511ca: 8159904: [TEST_BUG] Failure on solaris of java/awt/Window/MultiWindowApp/MultiWindowAppTest.java
  • f248ceb: 8265173: [test] divert spurious log output away from stream under test in ProcessBuilder Basic test
  • f5e2a9d: 8263897: compiler/c2/aarch64/TestVolatilesSerial.java failed with "java.lang.RuntimeException: Wrong method"
  • 89aec26: 8075909: [TEST_BUG] The regression-swing case failed as it does not have the 'Open' button when select 'subdir' folder with NimbusLAF
  • 456d4fb: 8159597: [TEST_BUG] closed/javax/swing/JPopupMenu/4760494/bug4760494.java leaves key pressed
  • 45d63a8: 8223140: Clean-up in 'ok_to_convert()'
  • 5d6ddbe: 8272783: Epsilon: Refactor tests to improve performance
  • 2897522: 8273606: Zero: SPARC64 build fails with si_band type mismatch
  • 5865def: 8272914: Create hotspot:tier2 and hotspot:tier3 test groups
  • ... and 7 more: https://git.openjdk.java.net/jdk11u-dev/compare/d86cf10b3425878f58cfdc7dc725905b4d94bf2f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@GoeLin Pushed as commit 7f5569c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant