Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265173: [test] divert spurious log output away from stream under test in ProcessBuilder Basic test #470

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 5, 2021

I backport this for parity with 11.0.14-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8265173: [test] divert spurious log output away from stream under test in ProcessBuilder Basic test

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/470/head:pull/470
$ git checkout pull/470

Update a local copy of the PR:
$ git checkout pull/470
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/470/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 470

View PR using the GUI difftool:
$ git pr show -t 470

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/470.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 5, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7b61a426e0837bde4885bd53397bba6b0939382f 8265173: [test] divert spurious log output away from stream under test in ProcessBuilder Basic test Oct 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8265173: [test] divert spurious log output away from stream under test in ProcessBuilder Basic test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 2b9261a: 8273894: ConcurrentModificationException raised every time ReferralsCache drops referral
  • a2bd0a9: 8272836: Limit run time for java/lang/invoke/LFCaching tests
  • 6f51eb4: 8273373: Zero: Cannot invoke JVM in primordial threads on Zero

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Oct 5, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 5, 2021

Webrevs

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Oct 6, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

Going to push as commit f248ceb.
Since your change was applied there have been 14 commits pushed to the master branch:

  • f5e2a9d: 8263897: compiler/c2/aarch64/TestVolatilesSerial.java failed with "java.lang.RuntimeException: Wrong method"
  • 89aec26: 8075909: [TEST_BUG] The regression-swing case failed as it does not have the 'Open' button when select 'subdir' folder with NimbusLAF
  • 456d4fb: 8159597: [TEST_BUG] closed/javax/swing/JPopupMenu/4760494/bug4760494.java leaves key pressed
  • 45d63a8: 8223140: Clean-up in 'ok_to_convert()'
  • 5d6ddbe: 8272783: Epsilon: Refactor tests to improve performance
  • 2897522: 8273606: Zero: SPARC64 build fails with si_band type mismatch
  • 5865def: 8272914: Create hotspot:tier2 and hotspot:tier3 test groups
  • ceccbc3: 8224829: AsyncSSLSocketClose.java has timing issue
  • ddc3288: 8250810: Push missing parts of JDK-8248817
  • 5de08c5: 8230067: Add optional automatic retry when running jtreg tests
  • ... and 4 more: https://git.openjdk.java.net/jdk11u-dev/compare/d86cf10b3425878f58cfdc7dc725905b4d94bf2f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@GoeLin Pushed as commit f248ceb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant