Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() #472

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Oct 5, 2021

Clean backport of JDK-8273924.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/472/head:pull/472
$ git checkout pull/472

Update a local copy of the PR:
$ git checkout pull/472
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/472/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 472

View PR using the GUI difftool:
$ git pr show -t 472

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/472.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 5, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport d39aad92308fbc28bd2de164e331062ebf62da85 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add() Oct 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 5, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 5, 2021

Webrevs

Loading

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Oct 6, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

Going to push as commit 58fe5e8.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 881ae69: 8274326: [macos] Ensure initialisation of sun/lwawt/macosx/CAccessibility in JavaComponentAccessibility.m
  • 7f5569c: 8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY"
  • 620726e: 8262438: sun/security/ssl/SSLLogger/LoggingFormatConsistency.java failed with "SocketException: Socket is closed"
  • 76511ca: 8159904: [TEST_BUG] Failure on solaris of java/awt/Window/MultiWindowApp/MultiWindowAppTest.java
  • f248ceb: 8265173: [test] divert spurious log output away from stream under test in ProcessBuilder Basic test
  • f5e2a9d: 8263897: compiler/c2/aarch64/TestVolatilesSerial.java failed with "java.lang.RuntimeException: Wrong method"
  • 89aec26: 8075909: [TEST_BUG] The regression-swing case failed as it does not have the 'Open' button when select 'subdir' folder with NimbusLAF
  • 456d4fb: 8159597: [TEST_BUG] closed/javax/swing/JPopupMenu/4760494/bug4760494.java leaves key pressed
  • 45d63a8: 8223140: Clean-up in 'ok_to_convert()'
  • 5d6ddbe: 8272783: Epsilon: Refactor tests to improve performance
  • ... and 4 more: https://git.openjdk.java.net/jdk11u-dev/compare/5de08c55fb3e26abd9a63c832a15f98769daed8c...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 6, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 6, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 6, 2021

@TheRealMDoerr Pushed as commit 58fe5e8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant