8252051: Make mlvmJvmtiUtils strncpy uses GCC 10.x friendly

[caojoshua]

Backport of 51a3b25. Removing Pragma's that ignore the stringop-truncation warning, which does not exist in tip. This backport eliminates the need for the warnings. The change is in test code so no danger of regressions in hotspot.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8252051: Make mlvmJvmtiUtils strncpy uses GCC 10.x friendly ⚠️ Issue is not open.

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/475/head:pull/475
$ git checkout pull/475

Update a local copy of the PR:
$ git checkout pull/475
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/475/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 475

View PR using the GUI difftool:
$ git pr show -t 475

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/475.diff

[bridgekeeper]

Hi @caojoshua, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user caojoshua" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[caojoshua]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[phohensee]

Joshua is an Amazon employee.

[mlbridge]

Webrevs

• 00: Full (b7b9bd95)

[phohensee]

Lgtm.

[openjdk]

@caojoshua This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8252051: Make mlvmJvmtiUtils strncpy uses GCC 10.x friendly

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 70 new commits pushed to the master branch:

• 2847e34: 8275131: Exceptions after a touchpad gesture on macOS
• 777ec9b: 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error
• bdf1d02: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
• 8faf1c7: 8198624: java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on mac
• fac11d3: 8233550: [TESTBUG] JTree tests fail regularly on MacOS
• 49681f2: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual
• 611d729: 8233647: [TESTBUG] JColorChooser/Test8051548.java is failing on macos
• b8c6841: 8233566: [TESTBUG] KeyboardFocusManager tests failing on MacoS
• a2628a0: 8233552: [TESTBUG] JTable Test bug7068740.java fails on MacOS
• 4a9c879: 8233553: [TESTBUG] JSpinner test bug4973721.java fails on MacOS
• ... and 60 more: https://git.openjdk.java.net/jdk11u-dev/compare/ddc3288b8cde25001244fee81896c98b1237affc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[caojoshua]

/integrate

[openjdk]

@caojoshua
Your change (at version b7b9bd9) is now ready to be sponsored by a Committer.

[phohensee]

I've tagged the issue, waiting for approval to integrate.

[RealCLanger]

/integrate

Hi Joshua,

you have to wait until a backport is approved in JBS via jdk11u-fix-yes label before invoking /integrate. No problem this time since you still need a sponsor but for the future...

And another hint: Please also activate GitHub Actions on your personal fork of jdk11u-dev to get some basic testing for the PR.

Cheers
Christoph

[RealCLanger]

/sponsor

[openjdk]

Going to push as commit b122119.
Since your change was applied there have been 70 commits pushed to the master branch:

• 2847e34: 8275131: Exceptions after a touchpad gesture on macOS
• 777ec9b: 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error
• bdf1d02: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
• 8faf1c7: 8198624: java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on mac
• fac11d3: 8233550: [TESTBUG] JTree tests fail regularly on MacOS
• 49681f2: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual
• 611d729: 8233647: [TESTBUG] JColorChooser/Test8051548.java is failing on macos
• b8c6841: 8233566: [TESTBUG] KeyboardFocusManager tests failing on MacoS
• a2628a0: 8233552: [TESTBUG] JTable Test bug7068740.java fails on MacOS
• 4a9c879: 8233553: [TESTBUG] JSpinner test bug4973721.java fails on MacOS
• ... and 60 more: https://git.openjdk.java.net/jdk11u-dev/compare/ddc3288b8cde25001244fee81896c98b1237affc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger @caojoshua Pushed as commit b122119.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.