New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8252051: Make mlvmJvmtiUtils strncpy uses GCC 10.x friendly #475
Conversation
Hi @caojoshua, welcome to this OpenJDK project and thanks for contributing! We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user caojoshua" as summary for the issue. If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing |
/covered |
Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated! |
Joshua is an Amazon employee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@caojoshua This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 70 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@caojoshua |
I've tagged the issue, waiting for approval to integrate. |
Hi Joshua, you have to wait until a backport is approved in JBS via jdk11u-fix-yes label before invoking /integrate. No problem this time since you still need a sponsor but for the future... And another hint: Please also activate GitHub Actions on your personal fork of jdk11u-dev to get some basic testing for the PR. Cheers |
/sponsor |
Going to push as commit b122119.
Your commit was automatically rebased without conflicts. |
@RealCLanger @caojoshua Pushed as commit b122119. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of 51a3b25. Removing Pragma's that ignore the stringop-truncation warning, which does not exist in tip. This backport eliminates the need for the warnings. The change is in test code so no danger of regressions in hotspot.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/475/head:pull/475
$ git checkout pull/475
Update a local copy of the PR:
$ git checkout pull/475
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/475/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 475
View PR using the GUI difftool:
$ git pr show -t 475
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/475.diff