Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273314: Add tier4 test groups #477

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 6, 2021

Semi-clean backport to improve testing in 11u. There seemed to a little trailing whitespace in langtools TEST.groups, which broke the cleanliness. I resolved that by hand. Attn @RealCLanger ;)

Additional testing:

  • Linux x86_64 fastdebug jdk:tier4 passes with a few known testbugs

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/477/head:pull/477
$ git checkout pull/477

Update a local copy of the PR:
$ git checkout pull/477
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/477/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 477

View PR using the GUI difftool:
$ git pr show -t 477

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/477.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2021

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1f8af524ffe2d2d1469d8f07887b1f61c6e4d7b8 8273314: Add tier4 test groups Oct 6, 2021
@openjdk
Copy link

openjdk bot commented Oct 6, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 6, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2021

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Looks good to me.

@openjdk
Copy link

openjdk bot commented Oct 7, 2021

@shipilev This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273314: Add tier4 test groups

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b1bab7f: 8272570: C2: crash in PhaseCFG::global_code_motion
  • 58fe5e8: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()
  • 881ae69: 8274326: [macos] Ensure initialisation of sun/lwawt/macosx/CAccessibility in JavaComponentAccessibility.m
  • 7f5569c: 8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 7, 2021
@shipilev
Copy link
Member Author

shipilev commented Oct 7, 2021

Thanks! Got the push approval as well.

/integrate

@openjdk
Copy link

openjdk bot commented Oct 7, 2021

Going to push as commit cbd6132.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 57aa3d8: 8199138: Add RISC-V support to Zero
  • b367f67: 8272180: Upgrade JSZip from v3.6.0 to v3.7.1
  • cbdb8c2: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182
  • b1bab7f: 8272570: C2: crash in PhaseCFG::global_code_motion
  • 58fe5e8: 8273924: ArrayIndexOutOfBoundsException thrown in java.util.JapaneseImperialCalendar.add()
  • 881ae69: 8274326: [macos] Ensure initialisation of sun/lwawt/macosx/CAccessibility in JavaComponentAccessibility.m
  • 7f5569c: 8254802: ThrowingPushPromisesAsStringCustom.java fails in "try throwing in GET_BODY"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2021
@openjdk
Copy link

openjdk bot commented Oct 7, 2021

@shipilev Pushed as commit cbd6132.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8273314 branch Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants