Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274381: missing CAccessibility definitions in JNI code #480

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Oct 6, 2021

Backport of JDK-8274381. Taken from 17u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274381: missing CAccessibility definitions in JNI code

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/480/head:pull/480
$ git checkout pull/480

Update a local copy of the PR:
$ git checkout pull/480
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/480/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 480

View PR using the GUI difftool:
$ git pr show -t 480

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/480.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a9981fb0ff11965128761ffd1d8fae1c44c7b9fb 8274381: missing CAccessibility definitions in JNI code Oct 6, 2021
@openjdk
Copy link

openjdk bot commented Oct 6, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 6, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274381: missing CAccessibility definitions in JNI code

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2021

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

1 similar comment
@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 7, 2021

Going to push as commit f859729.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 441b4de: 8274083: Update testing docs to mention tiered testing
  • cbd6132: 8273314: Add tier4 test groups
  • 57aa3d8: 8199138: Add RISC-V support to Zero
  • b367f67: 8272180: Upgrade JSZip from v3.6.0 to v3.7.1
  • cbdb8c2: 8272581: sun/security/pkcs11/Provider/MultipleLogins.sh fails after JDK-8266182

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 7, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 7, 2021
@openjdk
Copy link

openjdk bot commented Oct 7, 2021

@TheRealMDoerr Pushed as commit f859729.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Oct 7, 2021

@TheRealMDoerr The command integrate can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant