Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8265367: [macos-aarch64] 3 java/net/httpclient/websocket tests fail with "IOException: No buffer space available" #487

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 6, 2021

I want to downport this to jdk11u-dev so that downporting the follow up
"JDK-8268714: [macos-aarch64] 7 java/net/httpclient/websocket tests failed"
is more simple.

I had to resolve the following parts:

Copyright in several files.

PlainHttpConnection.java Change in a comment that was added in "8256459: java/net/httpclient/ManyRequests.java and java/net/httpclien..." does not apply. Skipped.

ProblemList: Tests removed were not problem listed.

PendingOperations.java:

  • imports due to context changes
  • cleanup(): Changes from "8249786: java/net/httpclient/websocket/PendingPingTextClose.java fails very infrequently" are missing. I added the output to System.err from that change.

PendingPingTextClose.java: Different indentation and line breaking.

PendingPongTextClose.java: Different context.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8265367: [macos-aarch64] 3 java/net/httpclient/websocket tests fail with "IOException: No buffer space available"

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/487/head:pull/487
$ git checkout pull/487

Update a local copy of the PR:
$ git checkout pull/487
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/487/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 487

View PR using the GUI difftool:
$ git pr show -t 487

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/487.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 24bf35f862e285eeca662b9829901c0f91d247d5 8265367: [macos-aarch64] 3 java/net/httpclient/websocket tests fail with "IOException: No buffer space available" Oct 6, 2021
@openjdk
Copy link

openjdk bot commented Oct 6, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 6, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2021

Webrevs

@theRealAph
Copy link
Contributor

theRealAph commented Oct 7, 2021

From the discussion at openjdk/jdk17#79, this is a dubious fix for some rather dubious tests. It touches a lot of shared runtime code which isn't broken. Surely this is a classic case of It Ain't Broke, Don't Fix It.

@GoeLin
Copy link
Member Author

GoeLin commented Oct 8, 2021

OK, I drop this. See also my reasoning in the comments of JDK-8268714.
(Actually the test changes do not depend on the runtime changes. So they also could just be omitted.)

@GoeLin GoeLin closed this Oct 8, 2021
@GoeLin GoeLin deleted the goetz_backport_8265367 branch Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants