Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M #49

Closed
wants to merge 1 commit into from

Conversation

@huishi-hs
Copy link

@huishi-hs huishi-hs commented Jun 22, 2021

Please help review backport of JDK-8264752 related to JFR.
This backport also includes successive build failure fix JDK-8266206 (for older gcc version).

Applied almost cleanly on jdk11u, except copyright year in license and ClassFileInstaller build/use in test/jdk/jdk/jfr/startupargs/TestBadOptionValues.java.

Tested on Linux X64 tier1/tier2/tier3 release/fastdebug no regression.
New test added in this PR also pass.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M ⚠️ Issue is not open.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/49/head:pull/49
$ git checkout pull/49

Update a local copy of the PR:
$ git checkout pull/49
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/49/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 49

View PR using the GUI difftool:
$ git pr show -t 49

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/49.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 22, 2021

👋 Welcome back hshi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jun 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 22, 2021

Webrevs

Loading

@huishi-hs huishi-hs changed the title 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M 8269109: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M Jun 22, 2021
@huishi-hs huishi-hs changed the title 8269109: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M 8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M Jun 22, 2021
@huishi-hs huishi-hs closed this Jun 22, 2021
@huishi-hs huishi-hs deleted the JFR_crash branch Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant