Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7105119: [TEST_BUG] [macosx] In test UIDefaults.toString() must be called with the invokeLater() #496

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 8, 2021

Backport of JDK-7105119. Applied clean but problemlist needed some resolving.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-7105119: [TEST_BUG] [macosx] In test UIDefaults.toString() must be called with the invokeLater()

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/496/head:pull/496
$ git checkout pull/496

Update a local copy of the PR:
$ git checkout pull/496
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/496/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 496

View PR using the GUI difftool:
$ git pr show -t 496

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/496.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 8, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 84fc4850a674f0f688cca2c6856e5656428707fc 7105119: [TEST_BUG] [macosx] In test UIDefaults.toString() must be called with the invokeLater() Oct 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7105119: [TEST_BUG] [macosx] In test UIDefaults.toString() must be called with the invokeLater()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 8, 2021

Webrevs

Loading

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Oct 11, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

Going to push as commit 82491fd.
Since your change was applied there have been 8 commits pushed to the master branch:

  • d66464e: 8237589: Fix copyright header formatting
  • 75b513f: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails
  • 84fc3b7: 8211148: var in implicit lambdas shouldn't be accepted for source < 11
  • 65cab1e: 8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac
  • 158c0a8: 8274642: jdk/jshell/CommandCompletionTest.java fails with NoSuchElementException after JDK-8271287
  • a88c738: 8271287: jdk/jshell/CommandCompletionTest.java fails with "lists don't have the same size expected"
  • f79ceaf: 8273498: compiler/c2/Test7179138_1.java timed out
  • eeab2f1: 8273229: Update OS detection code to recognize Windows Server 2022

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@RealCLanger Pushed as commit 82491fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@RealCLanger RealCLanger deleted the RealCLanger-backport-84fc4850 branch Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant