Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8211148: var in implicit lambdas shouldn't be accepted for source < 11 #497

Closed
wants to merge 1 commit into from

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 8, 2021

I would like to backport this to jdk11u-dev.

Applies clean except for trivial context resolve in Source.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8211148: var in implicit lambdas shouldn't be accepted for source < 11

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/497/head:pull/497
$ git checkout pull/497

Update a local copy of the PR:
$ git checkout pull/497
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/497/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 497

View PR using the GUI difftool:
$ git pr show -t 497

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/497.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 8, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 2589e9733e054c164a64112db80e25fefd6dd222 8211148: var in implicit lambdas shouldn't be accepted for source < 11 Oct 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 8, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 8, 2021

Webrevs

Loading

@GoeLin GoeLin force-pushed the goetz_backport_8211148 branch from 6685ef9 to 8c4b9b6 Oct 9, 2021
@openjdk openjdk bot added the clean label Oct 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8211148: var in implicit lambdas shouldn't be accepted for source < 11

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 158c0a8: 8274642: jdk/jshell/CommandCompletionTest.java fails with NoSuchElementException after JDK-8271287

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 9, 2021
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Oct 10, 2021

windows-x64-debug_testresults_hs_tier1_hotspot.zip missing in test artifacts.

Loading

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Oct 11, 2021

Windows CR failure: no test results available

Loading

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Oct 11, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

Going to push as commit 84fc3b7.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 65cab1e: 8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac
  • 158c0a8: 8274642: jdk/jshell/CommandCompletionTest.java fails with NoSuchElementException after JDK-8271287

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@GoeLin Pushed as commit 84fc3b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@GoeLin GoeLin deleted the goetz_backport_8211148 branch Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant