Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8211296: Remove HotSpot deprecation warning suppression for Mac/clang #5

Closed
wants to merge 1 commit into from

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Jun 1, 2021

Please review the backport of 8211296 to jdk11u-dev.
The first part of patch ( compitejvm.gmk) wasn't needed for jdk11u-dev
This is a prerequest for mac-aarch64 due to finite -> isfinite.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8211296: Remove HotSpot deprecation warning suppression for Mac/clang

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/5/head:pull/5
$ git checkout pull/5

Update a local copy of the PR:
$ git checkout pull/5
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/5/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 5

View PR using the GUI difftool:
$ git pr show -t 5

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/5.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 1, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cd95f5a933a13212fd27adba79c31d7dfccadb2e 8211296: Remove HotSpot deprecation warning suppression for Mac/clang Jun 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 1, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr labels Jun 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 1, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jun 2, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8211296: Remove HotSpot deprecation warning suppression for Mac/clang

Removed deprecation warning suppression, fixed uses of deprecated functions.

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2d76828: 8267695: Bump update version for OpenJDK: jdk-11.0.13

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jun 2, 2021
@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Jun 4, 2021

/integrate

@openjdk openjdk bot closed this Jun 4, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 4, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 4, 2021

@VladimirKempik Since your change was applied there have been 5 commits pushed to the master branch:

  • 006979a: 8257148: Remove obsolete code in AWTView.m
  • be0b9b1: 8266615: C2 incorrectly folds subtype checks involving an interface array
  • ab9d3de: 8261652: Remove some dead comments from os_bsd_x86
  • 09d3082: 8265231: (fc) ReadDirect and WriteDirect tests fail after fix for JDK-8264821
  • 2d76828: 8267695: Bump update version for OpenJDK: jdk-11.0.13

Your commit was automatically rebased without conflicts.

Pushed as commit 5c35022.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the JDK-8211296 branch Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants