Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273790: Potential cyclic dependencies between Gregorian and CalendarSystem #500

Closed

Conversation

@kelthuzadx
Copy link
Member

@kelthuzadx kelthuzadx commented Oct 9, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273790: Potential cyclic dependencies between Gregorian and CalendarSystem

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/500/head:pull/500
$ git checkout pull/500

Update a local copy of the PR:
$ git checkout pull/500
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/500/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 500

View PR using the GUI difftool:
$ git pr show -t 500

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/500.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 9, 2021

👋 Welcome back yyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport ddc262746aea99050b9a6484f51c7ddb8f4bc991 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem Oct 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2021

@kelthuzadx This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273790: Potential cyclic dependencies between Gregorian and CalendarSystem

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 94893a5: 8274840: Update OS detection code to recognize Windows 11
  • 596677e: 8251155: HostIdentifier fails to canonicalize hostnames starting with digits
  • b3926db: 8233638: [TESTBUG] Swing test ScreenMenuBarInputTwice.java fails on macos
  • 4bdcad5: 8233643: [TESTBUG] JMenu test bug4515762.java fails on macos
  • dfb97b0: 8233642: [TESTBUG] JMenuBar test bug 4750590.java fails on macos
  • 167c9f0: 8169953: JComboBox/8057893: ComboBoxEdited event is not fired! on Windows
  • 968c21e: 8272574: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 90d1bcb: 8261071: AArch64: Refactor interpreter native wrappers
  • 15931e5: 8230228: [TESTBUG] Several runtime/ErrorHandling tests may fail on some platforms
  • 15384ad: 8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails
  • ... and 17 more: https://git.openjdk.java.net/jdk11u-dev/compare/158c0a8c16974e1eb2021fd36f9032fb0f150a34...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 9, 2021

Webrevs

Loading

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 10, 2021

Hi, @kelthuzadx. Thanks for submitting this backport PR. Would you mind considering a 17u backport first? You'll also have to flag the JBS bug accordingly with jdk17u-fix-request and jdk11u-fix-request labels. And add a fix request comment justifying the backport. Thanks!

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Oct 11, 2021

Hi, @kelthuzadx. Thanks for submitting this backport PR. Would you mind considering a 17u backport first? You'll also have to flag the JBS bug accordingly with jdk17u-fix-request and jdk11u-fix-request labels. And add a fix request comment justifying the backport. Thanks!

I will firstly backport to jdk17 and then jdk11 later. Thanks for your kind reminder!

Loading

@kelthuzadx
Copy link
Member Author

@kelthuzadx kelthuzadx commented Oct 15, 2021

jdk11u-fix-yes was labeled. Let me integrate it.

/integrate

Loading

@openjdk openjdk bot added the sponsor label Oct 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2021

@kelthuzadx
Your change (at version fab758c) is now ready to be sponsored by a Committer.

Loading

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 15, 2021

/sponsor

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2021

Going to push as commit e2f8301.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 94893a5: 8274840: Update OS detection code to recognize Windows 11
  • 596677e: 8251155: HostIdentifier fails to canonicalize hostnames starting with digits
  • b3926db: 8233638: [TESTBUG] Swing test ScreenMenuBarInputTwice.java fails on macos
  • 4bdcad5: 8233643: [TESTBUG] JMenu test bug4515762.java fails on macos
  • dfb97b0: 8233642: [TESTBUG] JMenuBar test bug 4750590.java fails on macos
  • 167c9f0: 8169953: JComboBox/8057893: ComboBoxEdited event is not fired! on Windows
  • 968c21e: 8272574: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 90d1bcb: 8261071: AArch64: Refactor interpreter native wrappers
  • 15931e5: 8230228: [TESTBUG] Several runtime/ErrorHandling tests may fail on some platforms
  • 15384ad: 8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails
  • ... and 17 more: https://git.openjdk.java.net/jdk11u-dev/compare/158c0a8c16974e1eb2021fd36f9032fb0f150a34...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2021

@RealCLanger @kelthuzadx Pushed as commit e2f8301.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants