Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher #502

Closed
wants to merge 1 commit into from

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 9, 2021

I backport this for parity with 11.0.14-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/502/head:pull/502
$ git checkout pull/502

Update a local copy of the PR:
$ git checkout pull/502
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/502/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 502

View PR using the GUI difftool:
$ git pr show -t 502

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/502.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 9, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport a5108a605e6a1e427d90dbeeb8630a3d01d6b405 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher Oct 9, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 9, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 9, 2021

Webrevs

Loading

@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Oct 12, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

Going to push as commit 7410b74.
Since your change was applied there have been 10 commits pushed to the master branch:

  • fc2646b: 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern
  • aa5d5f3: 8245147: Refactor and improve utility of test/langtools/tools/javac/versions/Versions.java
  • 9512c47: 8273826: Correct Manifest file name and NPE checks
  • bcee700: 8273961: jdk/nio/zipfs/ZipFSTester.java fails if file path contains '+' character
  • 4e63adb: 8242793: Incorrect copyright header in ContinuousCallSiteTargetChange.java
  • 82491fd: 7105119: [TEST_BUG] [macosx] In test UIDefaults.toString() must be called with the invokeLater()
  • d66464e: 8237589: Fix copyright header formatting
  • 75b513f: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails
  • 84fc3b7: 8211148: var in implicit lambdas shouldn't be accepted for source < 11
  • 65cab1e: 8198616: java/awt/Focus/6378278/InputVerifierTest.java fails on mac

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 12, 2021

@GoeLin Pushed as commit 7410b74.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant