Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261071: AArch64: Refactor interpreter native wrappers #507

Conversation

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Oct 11, 2021

Clean backport from upstream. Macos-aarch64 prerequest.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8261071: AArch64: Refactor interpreter native wrappers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/507/head:pull/507
$ git checkout pull/507

Update a local copy of the PR:
$ git checkout pull/507
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/507/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 507

View PR using the GUI difftool:
$ git pr show -t 507

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/507.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 11, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 682e78e89b35c05590a5bc490e87ae3cab864c02 8261071: AArch64: Refactor interpreter native wrappers Oct 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261071: AArch64: Refactor interpreter native wrappers

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 11, 2021

Webrevs

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 11, 2021

@VladimirKempik Is there somewhere an overview about which changes are still missing to support macos aarch64 in JDK11u?

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Oct 11, 2021

it's pretty easy to find, most of patches to jdk/jdk authored by me or @AntonKozlov between july2020 and febr2021
The most significant left is MAP_JIT support. rest is minor AFAIR. Then the JEP-391 itself can go ( after jep-388 of course)
We have contributed many fixes needed by JEP-391 as separate patches as they weren't macos-aarch64 specific. That was smart idea for jdk17 ( allowed to downsize PR for jep-391 itself) but it now bites us back when we want to backport everything to jdk11.

btw, I'm waiting for some tests to finish before putting fix request on jbs bug.

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Oct 14, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

Going to push as commit 90d1bcb.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 15931e5: 8230228: [TESTBUG] Several runtime/ErrorHandling tests may fail on some platforms
  • 15384ad: 8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails
  • 4557503: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
  • 844c504: 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity
  • 4940e2e: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing
  • 0a71d8e: 8221305: java/awt/FontMetrics/MaxAdvanceIsMax.java fails on MacOS + Solaris
  • d336b24: 8253015: Aarch64: Move linux code out from generic CPU feature detection
  • 2a028c4: 8180568: Refactor javax/crypto shell tests to plain java tests
  • 7410b74: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher
  • fc2646b: 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern
  • ... and 3 more: https://git.openjdk.java.net/jdk11u-dev/compare/4e63adb56e6469a158d64fcc5e04045deb51ec60...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@VladimirKempik Pushed as commit 90d1bcb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the backport-682e78e89b35c05590a5bc490e87ae3cab864c02 branch Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants