8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity

[TheRealMDoerr]

Backport of JDK-8271459. Fix applies almost cleanly (ciSymbol was renamed to ciSymbols). Skipped tests because IR test framework is not in 11u.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity

Reviewers

• Goetz Lindenmaier (@GoeLin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/510/head:pull/510
$ git checkout pull/510

Update a local copy of the PR:
$ git checkout pull/510
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 510

View PR using the GUI difftool:
$ git pr show -t 510

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/510.diff

[bridgekeeper]

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (5829ee24)

[GoeLin]

A bummer the tests can not be backported.
Functional change is fine.

[openjdk]

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 2a028c4: 8180568: Refactor javax/crypto shell tests to plain java tests
• 7410b74: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher
• fc2646b: 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern
• aa5d5f3: 8245147: Refactor and improve utility of test/langtools/tools/javac/versions/Versions.java

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TheRealMDoerr]

Thanks for the review and the approval!
/integrate

[openjdk]

Going to push as commit 844c504.
Since your change was applied there have been 7 commits pushed to the master branch:

• 4940e2e: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing
• 0a71d8e: 8221305: java/awt/FontMetrics/MaxAdvanceIsMax.java fails on MacOS + Solaris
• d336b24: 8253015: Aarch64: Move linux code out from generic CPU feature detection
• 2a028c4: 8180568: Refactor javax/crypto shell tests to plain java tests
• 7410b74: 8273646: Add openssl from path variable also in to Default System Openssl Path in OpensslArtifactFetcher
• fc2646b: 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern
• aa5d5f3: 8245147: Refactor and improve utility of test/langtools/tools/javac/versions/Versions.java

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr Pushed as commit 844c504.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.