Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233642: [TESTBUG] JMenuBar test bug 4750590.java fails on macos #511

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 11, 2021

Hi all,

this pull request contains a backport of JDK-8233642 from the openjdk/jdk repository.

The commit being backported was authored by Prasanta Sadhukhan on 8 May 2020 and was reviewed by Sergey Bylokhov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233642: [TESTBUG] JMenuBar test bug 4750590.java fails on macos

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/511/head:pull/511
$ git checkout pull/511

Update a local copy of the PR:
$ git checkout pull/511
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/511/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 511

View PR using the GUI difftool:
$ git pr show -t 511

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/511.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 11, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5f0d11e1e9fa4907a30737a22b6abafc1242e526 8233642: [TESTBUG] JMenuBar test bug 4750590.java fails on macos Oct 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 11, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233642: [TESTBUG] JMenuBar test bug 4750590.java  fails on macos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Oct 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 11, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Oct 14, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

Going to push as commit dfb97b0.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 167c9f0: 8169953: JComboBox/8057893: ComboBoxEdited event is not fired! on Windows
  • 968c21e: 8272574: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 90d1bcb: 8261071: AArch64: Refactor interpreter native wrappers
  • 15931e5: 8230228: [TESTBUG] Several runtime/ErrorHandling tests may fail on some platforms
  • 15384ad: 8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails
  • 4557503: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
  • 844c504: 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity
  • 4940e2e: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing
  • 0a71d8e: 8221305: java/awt/FontMetrics/MaxAdvanceIsMax.java fails on MacOS + Solaris
  • d336b24: 8253015: Aarch64: Move linux code out from generic CPU feature detection
  • ... and 4 more: https://git.openjdk.java.net/jdk11u-dev/compare/9512c471e9ab0830d8d5b2275803f59a0f073fcb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 14, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@RealCLanger Pushed as commit dfb97b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant