New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8251155: HostIdentifier fails to canonicalize hostnames starting with digits #516
Conversation
|
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@DamonFool This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 11 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.
|
Thanks @GoeLin for your review. Fix request had been approved. /integrate |
@DamonFool |
/sponsor |
Going to push as commit 596677e.
Your commit was automatically rebased without conflicts. |
@GoeLin @DamonFool Pushed as commit 596677e. |
Thanks @GoeLin for sponsoring. |
Hi all,
I'd like to backport JDK-8251155 to jdk11u.
Tools like jps in jdk11u still fail on machines when the hostnames starting with digits.
And this bug can be reproduced by jtreg tests:
It's worth doing this since quite a lot of cloud hosts are named with digits only.
Although patch can be applied cleanly, the backported test has been adjusted (see the following diff) to make it successfully compiled with the jdk11 test framework.
Testing:
Thanks.
Best regards,
Jie
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/516/head:pull/516
$ git checkout pull/516
Update a local copy of the PR:
$ git checkout pull/516
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/516/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 516
View PR using the GUI difftool:
$ git pr show -t 516
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/516.diff