Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails #517

Closed
wants to merge 1 commit into from

Conversation

theaoqi
Copy link
Member

@theaoqi theaoqi commented Oct 13, 2021

The test also fails in jdk11u. The patch does not apply cleanly due to context difference, but it is easy to resolve manually. Low risk, only a test change.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/517/head:pull/517
$ git checkout pull/517

Update a local copy of the PR:
$ git checkout pull/517
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/517/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 517

View PR using the GUI difftool:
$ git pr show -t 517

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/517.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 13, 2021

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@theaoqi theaoqi changed the title Backport 5fedb69e Backport 5fedb69e66f55960bc334db951fc8224fea8489e Oct 13, 2021
@openjdk openjdk bot changed the title Backport 5fedb69e66f55960bc334db951fc8224fea8489e 8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 13, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 13, 2021

Webrevs

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@theaoqi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8250888: nsk/jvmti/scenarios/general_functions/GF08/gf08t001/TestDriver.java fails

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 13, 2021
@theaoqi
Copy link
Member Author

theaoqi commented Oct 13, 2021

Got the jdk11u-fix-yes.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@theaoqi
Your change (at version ca36494) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 13, 2021

Going to push as commit 15384ad.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 4557503: 8269656: The test test/langtools/tools/javac/versions/Versions.java has duplicate test cycles
  • 844c504: 8271459: C2: Missing NegativeArraySizeException when creating StringBuilder with negative capacity
  • 4940e2e: 8137101: [TEST_BUG] javax/swing/plaf/basic/BasicHTML/4251579/bug4251579.java failure due to timing

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 13, 2021
@openjdk
Copy link

openjdk bot commented Oct 13, 2021

@RealCLanger @theaoqi Pushed as commit 15384ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants