-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8264752: SIGFPE crash with option FlightRecorderOptions:threadbuffersize=30M #52
Conversation
👋 Welcome back hshi! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/issue JDK-8266206 |
@RealCLanger Only the author (@huishi-hs) is allowed to issue the |
@huishi-hs, I would prefer to see JDK-8266206 backported in a separate PR/commit. Is that possible? Thanks! |
@RealCLanger Thanks! In my understanding, you prefer two separate PRs for JDK-8264752 and JDK-8266206 backport. The second one must base on the first one and two must be integrated at same time. Is there any instructions for backporting in this way? |
Your understanding is correct. Unfortunately it is not possible with GitHub/Skara to merge two commits in one PR. Those would automatically be squashed. |
@RealCLanger Thanks for your detail description! After removing JDK-8266206 change, it fails build on jdk11u-dev. However it doesn't fail when removing JDK-8266206 change and build on jdk17. Build on same machine with same gcc verison 7.5.0. This PR is updated to backport of JDK-8264752 only and I have tested JDK-8266206's change can apply cleanly. |
The safest way might combine these two commit integrated at same time. |
/issue JDK-8266206 |
@huishi-hs |
@RealCLanger JDK-8266206 issue is added, could you please review this PR again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now. I think it is the best to merge these two patches at once, accepting they get squashed. If you'd take the original change for JDK-8264752 only the build would break. I verified this and I also verified that no regressions occur in our internal test systems. Good to go. :)
@huishi-hs This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Thanks for yoru review and test verify! |
/integrate |
@huishi-hs |
/sponsor |
Going to push as commit df587c7.
Your commit was automatically rebased without conflicts. |
@RealCLanger @huishi-hs Pushed as commit df587c7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please help review backport of JDK-8264752 related to JFR.
This backport also includes successive build failure fix JDK-8266206 (for older gcc version).
Applied almost cleanly on jdk11u, except copyright year in license and ClassFileInstaller build/use in test/jdk/jdk/jfr/startupargs/TestBadOptionValues.java.
Tested on Linux X64 tier1/tier2/tier3 release/fastdebug no regression. test/jdk/jdk/jfr test pass with release/fastdebug.
New test added in this PR also pass.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/52/head:pull/52
$ git checkout pull/52
Update a local copy of the PR:
$ git checkout pull/52
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/52/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 52
View PR using the GUI difftool:
$ git pr show -t 52
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/52.diff