Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239334: Tab Size does not work correctly in JTextArea with setLineWrap on #520

Conversation

@TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Oct 14, 2021

Clean backport of JDK-8239334.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8239334: Tab Size does not work correctly in JTextArea with setLineWrap on

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/520/head:pull/520
$ git checkout pull/520

Update a local copy of the PR:
$ git checkout pull/520
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/520/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 520

View PR using the GUI difftool:
$ git pr show -t 520

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/520.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 14, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 3c72042627a02c2ad12a909fc76a082d902bc35d 8239334: Tab Size does not work correctly in JTextArea with setLineWrap on Oct 14, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 14, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8239334: Tab Size does not work correctly in JTextArea with setLineWrap on

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 14, 2021

Webrevs

Loading

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 14, 2021

Did you run the headful test and check that it passes?

Loading

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Oct 14, 2021

==============================
Test summary
==============================
   TEST                                              TOTAL  PASS  FAIL ERROR   
   jtreg:test/jdk/javax/swing/JTextArea/TestTabSizeWithLineWrap.java
                                                         1     1     0     0   
==============================
TEST SUCCESS

Loading

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Oct 15, 2021

Thanks for the approval!
/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2021

Going to push as commit 99ff268.
Since your change was applied there have been 7 commits pushed to the master branch:

  • e2f8301: 8273790: Potential cyclic dependencies between Gregorian and CalendarSystem
  • 94893a5: 8274840: Update OS detection code to recognize Windows 11
  • 596677e: 8251155: HostIdentifier fails to canonicalize hostnames starting with digits
  • b3926db: 8233638: [TESTBUG] Swing test ScreenMenuBarInputTwice.java fails on macos
  • 4bdcad5: 8233643: [TESTBUG] JMenu test bug4515762.java fails on macos
  • dfb97b0: 8233642: [TESTBUG] JMenuBar test bug 4750590.java fails on macos
  • 167c9f0: 8169953: JComboBox/8057893: ComboBoxEdited event is not fired! on Windows

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 15, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 15, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 15, 2021

@TheRealMDoerr Pushed as commit 99ff268.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants