Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233559: [TESTBUG] TestNimbusOverride.java is failing on macos #524

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 15, 2021

Backport of 8233559: [TESTBUG] TestNimbusOverride.java is failing on macos


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233559: [TESTBUG] TestNimbusOverride.java is failing on macos

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/524/head:pull/524
$ git checkout pull/524

Update a local copy of the PR:
$ git checkout pull/524
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/524/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 524

View PR using the GUI difftool:
$ git pr show -t 524

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/524.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c6386188143df45bb0a2e72812075cad22c650e4 8233559: [TESTBUG] TestNimbusOverride.java is failing on macos Oct 15, 2021
@openjdk
Copy link

openjdk bot commented Oct 15, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 15, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233559: [TESTBUG] TestNimbusOverride.java is failing on macos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Oct 15, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 15, 2021

Webrevs

@RealCLanger RealCLanger force-pushed the RealCLanger-backport-c6386188 branch from e4baa3e to 0f1e16b Compare Oct 16, 2021
@RealCLanger RealCLanger changed the base branch from master to pr/523 Oct 16, 2021
@openjdk openjdk bot removed the ready label Oct 16, 2021
@openjdk-notifier openjdk-notifier bot changed the base branch from pr/523 to master Oct 19, 2021
@openjdk-notifier
Copy link

openjdk-notifier bot commented Oct 19, 2021

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout RealCLanger-backport-04b3bf60
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Oct 19, 2021
@RealCLanger RealCLanger force-pushed the RealCLanger-backport-c6386188 branch from 0f1e16b to e05a73f Compare Oct 19, 2021
@openjdk openjdk bot added clean ready labels Oct 19, 2021
@RealCLanger
Copy link
Contributor Author

RealCLanger commented Oct 20, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2021

Going to push as commit bab6d94.
Since your change was applied there have been 5 commits pushed to the master branch:

  • b122119: 8252051: Make mlvmJvmtiUtils strncpy uses GCC 10.x friendly
  • 2847e34: 8275131: Exceptions after a touchpad gesture on macOS
  • 777ec9b: 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error
  • bdf1d02: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 8faf1c7: 8198624: java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on mac

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 20, 2021
@openjdk
Copy link

openjdk bot commented Oct 20, 2021

@RealCLanger Pushed as commit bab6d94.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-c6386188 branch Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant