Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239827: The test OpenByUNCPathNameTest.java should be changed to be manual #528

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 16, 2021

Hi all,

this pull request contains a backport of JDK-8239827 from the openjdk/jdk repository.

The commit being backported was authored by Tejpal Rebari on 28 May 2020 and was reviewed by Prasanta Sadhukhan.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8239827: The test OpenByUNCPathNameTest.java should be changed to be manual

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/528/head:pull/528
$ git checkout pull/528

Update a local copy of the PR:
$ git checkout pull/528
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/528/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 528

View PR using the GUI difftool:
$ git pr show -t 528

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/528.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 16, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7cc3ba5f9b188e5dd298dbcde3934d08b6101032 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual Oct 16, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 16, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8239827: The test OpenByUNCPathNameTest.java should be changed to be manual

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 16, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Oct 18, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

Going to push as commit 49681f2.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 611d729: 8233647: [TESTBUG] JColorChooser/Test8051548.java is failing on macos
  • b8c6841: 8233566: [TESTBUG] KeyboardFocusManager tests failing on MacoS
  • a2628a0: 8233552: [TESTBUG] JTable Test bug7068740.java fails on MacOS
  • 4a9c879: 8233553: [TESTBUG] JSpinner test bug4973721.java fails on MacOS
  • 2c4ab76: 8267652: c2 loop unrolling by 8 results in reading memory past array

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@RealCLanger Pushed as commit 49681f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant