Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated #529

Closed
wants to merge 1 commit into from

Conversation

xpbob
Copy link

@xpbob xpbob commented Oct 18, 2021

Backport 252aaa9249d8979366b37d59487b5b039d923e35


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/529/head:pull/529
$ git checkout pull/529

Update a local copy of the PR:
$ git checkout pull/529
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/529/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 529

View PR using the GUI difftool:
$ git pr show -t 529

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/529.diff

@xpbob
Copy link
Author

xpbob commented Oct 18, 2021

Backport 252aaa9249d8979366b37d59487b5b039d923e35

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2021

👋 Welcome back xpbob! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 252aaa9249d8979366b37d59487b5b039d923e35 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated Oct 18, 2021
@openjdk
Copy link

openjdk bot commented Oct 18, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 18, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@xpbob This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 49681f2: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual
  • 611d729: 8233647: [TESTBUG] JColorChooser/Test8051548.java is failing on macos
  • b8c6841: 8233566: [TESTBUG] KeyboardFocusManager tests failing on MacoS
  • a2628a0: 8233552: [TESTBUG] JTable Test bug7068740.java fails on MacOS
  • 4a9c879: 8233553: [TESTBUG] JSpinner test bug4973721.java fails on MacOS
  • 2c4ab76: 8267652: c2 loop unrolling by 8 results in reading memory past array

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 19, 2021
@xpbob
Copy link
Author

xpbob commented Oct 19, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 19, 2021
@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@xpbob
Your change (at version 82792dd) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 19, 2021

Going to push as commit bdf1d02.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 8faf1c7: 8198624: java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on mac
  • fac11d3: 8233550: [TESTBUG] JTree tests fail regularly on MacOS
  • 49681f2: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual
  • 611d729: 8233647: [TESTBUG] JColorChooser/Test8051548.java is failing on macos
  • b8c6841: 8233566: [TESTBUG] KeyboardFocusManager tests failing on MacoS
  • a2628a0: 8233552: [TESTBUG] JTable Test bug7068740.java fails on MacOS
  • 4a9c879: 8233553: [TESTBUG] JSpinner test bug4973721.java fails on MacOS
  • 2c4ab76: 8267652: c2 loop unrolling by 8 results in reading memory past array

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 19, 2021
@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@RealCLanger @xpbob Pushed as commit bdf1d02.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants