Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267751: (test) jtreg.SkippedException has no serial VersionUID #53

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jun 22, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267751: (test) jtreg.SkippedException has no serial VersionUID

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/53/head:pull/53
$ git checkout pull/53

Update a local copy of the PR:
$ git checkout pull/53
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/53/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 53

View PR using the GUI difftool:
$ git pr show -t 53

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/53.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jun 22, 2021

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0fc7c8d101d526f1bc86831996b6883209d77451 8267751: (test) jtreg.SkippedException has no serial VersionUID Jun 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jun 22, 2021

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8267751: (test) jtreg.SkippedException has no serial VersionUID

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • 3c54e03: 8251945: SIGSEGV in PackageEntry::purge_qualified_exports()
  • cbe9c1b: 8213137: Remove static initialization of monitor/mutex instances
  • e44258c: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
  • 9420012: 8024368: private methods are allocated vtable indices
  • cfdfee7: 8241353: NPE in ToolProvider.getSystemJavaCompiler
  • 0605504: 8181313: SA: Remove libthread_db dependency on Linux
  • 23719ae: 8262000: jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java failed with "OutOfMemoryError: Java heap space"
  • 9638c41: 8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong
  • 57d8e1e: 8268127: Shenandoah: Heap size may be too small for region to align to large page size
  • 4e19090: 8268103: JNI functions incorrectly return a double after JDK-8265836
  • ... and 7 more: https://git.openjdk.java.net/jdk11u-dev/compare/f55ef1e033a769101e383792c3964da275fd4582...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jun 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jun 22, 2021

Webrevs

@jerboaa
Copy link
Contributor Author

@jerboaa jerboaa commented Jun 23, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

Going to push as commit 3f67b07.
Since your change was applied there have been 19 commits pushed to the master branch:

  • 46fd6d2: 8263382: java/util/logging/ParentLoggersTest.java failed with "checkLoggers: getLoggerNames() returned unexpected loggers"
  • 881100f: 8233989: Create an IPv4 version of java/net/MulticastSocket/SetLoopbackMode.java
  • 3c54e03: 8251945: SIGSEGV in PackageEntry::purge_qualified_exports()
  • cbe9c1b: 8213137: Remove static initialization of monitor/mutex instances
  • e44258c: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5
  • 9420012: 8024368: private methods are allocated vtable indices
  • cfdfee7: 8241353: NPE in ToolProvider.getSystemJavaCompiler
  • 0605504: 8181313: SA: Remove libthread_db dependency on Linux
  • 23719ae: 8262000: jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java failed with "OutOfMemoryError: Java heap space"
  • 9638c41: 8266288: assert root method not found in witnessed_reabstraction_in_supers is too strong
  • ... and 9 more: https://git.openjdk.java.net/jdk11u-dev/compare/f55ef1e033a769101e383792c3964da275fd4582...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jun 23, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jun 23, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jun 23, 2021

@jerboaa Pushed as commit 3f67b07.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant