Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream #530

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 18, 2021

I backport this for parity with 11.0.15-oracle.

I did the following changes to the patch:

  • I also include the changes from "8222938 Replace wildcard address with loopback or local host in tests - part 21".
    As this is a cleanup it is pointless to undo all the changes in the patch.
  • I removed "...".formatted() calls. That is not supported in 11.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/530/head:pull/530
$ git checkout pull/530

Update a local copy of the PR:
$ git checkout pull/530
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/530/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 530

View PR using the GUI difftool:
$ git pr show -t 530

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/530.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5caa77b043ae490c3d7d56d181d0e07e6b859b9e 8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream Oct 18, 2021
@openjdk
Copy link

openjdk bot commented Oct 18, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 18, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2021

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the test almost the same as the upstream version (except the formatted usages which are not supported in 11u). Nice!

@openjdk
Copy link

openjdk bot commented Oct 18, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 18, 2021
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2021

@GoeLin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 13, 2021

@GoeLin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Dec 13, 2021
@GoeLin GoeLin deleted the goetz_backport_8263364 branch January 20, 2022 19:39
@GoeLin GoeLin restored the goetz_backport_8263364 branch March 17, 2022 08:09
@GoeLin GoeLin deleted the goetz_backport_8263364 branch March 17, 2022 08:09
@GoeLin GoeLin restored the goetz_backport_8263364 branch March 18, 2022 13:20
@GoeLin GoeLin deleted the goetz_backport_8263364 branch April 1, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants