-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8263364: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java wedged in getInputStream #530
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
c37c5c8
to
fa24335
Compare
fa24335
to
72fa658
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes the test almost the same as the upstream version (except the formatted
usages which are not supported in 11u). Nice!
@GoeLin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
@GoeLin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@GoeLin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
I backport this for parity with 11.0.15-oracle.
I did the following changes to the patch:
As this is a cleanup it is pointless to undo all the changes in the patch.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/530/head:pull/530
$ git checkout pull/530
Update a local copy of the PR:
$ git checkout pull/530
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/530/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 530
View PR using the GUI difftool:
$ git pr show -t 530
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/530.diff