-
Notifications
You must be signed in to change notification settings - Fork 251
8261075: Create stubRoutines.inline.hpp with SafeFetch implementation #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
I have built linux32/64, win32/64, solaris x64/sparcv9 (hotspot only), linux-aarch64, macos-x64, all went well with this change |
|
@VladimirKempik This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tests have passed.
|
/integrate |
|
Going to push as commit eb03bf7.
Your commit was automatically rebased without conflicts. |
|
@VladimirKempik Pushed as commit eb03bf7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this backport of 8261075 to jdk11u-dev.
Not applying cleanly mostly due to some context code difference and miss of zgc.
It's just code location refactoring, no actual code changed.
It's a prerequest for mac-aarch64 jep backport.
This will soon be followed by backport of 8263068.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/532/head:pull/532$ git checkout pull/532Update a local copy of the PR:
$ git checkout pull/532$ git pull https://git.openjdk.java.net/jdk11u-dev pull/532/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 532View PR using the GUI difftool:
$ git pr show -t 532Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/532.diff