Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261075: Create stubRoutines.inline.hpp with SafeFetch implementation #532

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Oct 18, 2021

Please review this backport of 8261075 to jdk11u-dev.
Not applying cleanly mostly due to some context code difference and miss of zgc.
It's just code location refactoring, no actual code changed.
It's a prerequest for mac-aarch64 jep backport.
This will soon be followed by backport of 8263068.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261075: Create stubRoutines.inline.hpp with SafeFetch implementation

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/532/head:pull/532
$ git checkout pull/532

Update a local copy of the PR:
$ git checkout pull/532
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/532/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 532

View PR using the GUI difftool:
$ git pr show -t 532

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/532.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 18, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport b955f85e03bafe8ce39677d0af06bf1ceb7e2cbb 8261075: Create stubRoutines.inline.hpp with SafeFetch implementation Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 18, 2021

Webrevs

Loading

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Oct 18, 2021

I have built linux32/64, win32/64, solaris x64/sparcv9 (hotspot only), linux-aarch64, macos-x64, all went well with this change

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261075: Create stubRoutines.inline.hpp with SafeFetch implementation

Reviewed-by: phh, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 777ec9b: 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error
  • bdf1d02: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 8faf1c7: 8198624: java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on mac
  • fac11d3: 8233550: [TESTBUG] JTree tests fail regularly on MacOS
  • 49681f2: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual
  • 611d729: 8233647: [TESTBUG] JColorChooser/Test8051548.java is failing on macos
  • b8c6841: 8233566: [TESTBUG] KeyboardFocusManager tests failing on MacoS
  • a2628a0: 8233552: [TESTBUG] JTable Test bug7068740.java fails on MacOS

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 18, 2021
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

LGTM. Tests have passed.

Loading

@VladimirKempik
Copy link
Author

@VladimirKempik VladimirKempik commented Oct 20, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2021

Going to push as commit eb03bf7.
Since your change was applied there have been 12 commits pushed to the master branch:

  • d5017c3: 8270517: Add Zero support for LoongArch
  • bab6d94: 8233559: [TESTBUG] TestNimbusOverride.java is failing on macos
  • b122119: 8252051: Make mlvmJvmtiUtils strncpy uses GCC 10.x friendly
  • 2847e34: 8275131: Exceptions after a touchpad gesture on macOS
  • 777ec9b: 8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java OCSP response error
  • bdf1d02: 8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated
  • 8faf1c7: 8198624: java/awt/KeyboardFocusmanager/TypeAhead/SubMenuShowTest/SubMenuShowTest.html fails on mac
  • fac11d3: 8233550: [TESTBUG] JTree tests fail regularly on MacOS
  • 49681f2: 8239827: The test OpenByUNCPathNameTest.java should be changed to be manual
  • 611d729: 8233647: [TESTBUG] JColorChooser/Test8051548.java is failing on macos
  • ... and 2 more: https://git.openjdk.java.net/jdk11u-dev/compare/4a9c879e66e501b43fcd459e656437df35a16834...master

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 20, 2021

@VladimirKempik Pushed as commit eb03bf7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@VladimirKempik VladimirKempik deleted the JDK-8261075 branch Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants