Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8207936: TestZipFile failed with java.lang.AssertionError exception #535

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Oct 19, 2021

Clean Backport of JDK-8207936.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8207936: TestZipFile failed with java.lang.AssertionError exception

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/535/head:pull/535
$ git checkout pull/535

Update a local copy of the PR:
$ git checkout pull/535
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/535/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 535

View PR using the GUI difftool:
$ git pr show -t 535

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/535.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 65455ff60b4f33996c698029e0b2cff65c7f45f5 8207936: TestZipFile failed with java.lang.AssertionError exception Oct 19, 2021
@openjdk
Copy link

openjdk bot commented Oct 19, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 19, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8207936: TestZipFile failed with java.lang.AssertionError exception

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 19, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2021

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Oct 20, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 20, 2021

Going to push as commit f62113a.
Since your change was applied there have been 4 commits pushed to the master branch:

  • eb03bf7: 8261075: Create stubRoutines.inline.hpp with SafeFetch implementation
  • d5017c3: 8270517: Add Zero support for LoongArch
  • bab6d94: 8233559: [TESTBUG] TestNimbusOverride.java is failing on macos
  • b122119: 8252051: Make mlvmJvmtiUtils strncpy uses GCC 10.x friendly

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2021
@openjdk
Copy link

openjdk bot commented Oct 20, 2021

@TheRealMDoerr Pushed as commit f62113a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant