Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239422: [TESTBUG] compiler/c1/TestPrintIRDuringConstruction.java failed when C1 is disabled #544

Closed
wants to merge 1 commit into from

Conversation

theaoqi
Copy link
Member

@theaoqi theaoqi commented Oct 20, 2021

The patch applies clean. Low risk, only test changes. The modified test passed on linux-x64 with and without compiler1 (without c1: no tests selected).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8239422: [TESTBUG] compiler/c1/TestPrintIRDuringConstruction.java failed when C1 is disabled

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/544/head:pull/544
$ git checkout pull/544

Update a local copy of the PR:
$ git checkout pull/544
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/544/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 544

View PR using the GUI difftool:
$ git pr show -t 544

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/544.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 20, 2021

👋 Welcome back aoqi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport eef02376bd29ef224566bdf9040967bb09b8f887 8239422: [TESTBUG] compiler/c1/TestPrintIRDuringConstruction.java failed when C1 is disabled Oct 20, 2021
@openjdk
Copy link

openjdk bot commented Oct 20, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 20, 2021

@theaoqi This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8239422: [TESTBUG] compiler/c1/TestPrintIRDuringConstruction.java failed when C1 is disabled

Skip test if C1 is not available.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1297c26: 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 20, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 20, 2021

Webrevs

@theaoqi
Copy link
Member Author

theaoqi commented Oct 21, 2021

Got the jdk11u-fix-yes.

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 21, 2021
@openjdk
Copy link

openjdk bot commented Oct 21, 2021

@theaoqi
Your change (at version 2d01bc7) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 21, 2021

Going to push as commit 25c33bc.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 00255bd: 8263068: Rename safefetch.hpp to safefetch.inline.hpp
  • 1297c26: 8275051: Shenandoah: Correct ordering of requested gc cause and gc request flag

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 21, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 21, 2021
@openjdk
Copy link

openjdk bot commented Oct 21, 2021

@RealCLanger @theaoqi Pushed as commit 25c33bc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants