Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8220575: Correctly format test URI's that contain a retrieved IPv6 address #547

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 21, 2021

Backport of JDK-8220575.
/net/httpclient/AuthSchemesTest.java does not exist in 11u
test/jdk/sun/net/www/protocol/http/RedirectOnPost.java needed trivial resolving.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8220575: Correctly format test URI's that contain a retrieved IPv6 address

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/547/head:pull/547
$ git checkout pull/547

Update a local copy of the PR:
$ git checkout pull/547
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/547/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 547

View PR using the GUI difftool:
$ git pr show -t 547

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/547.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 21, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 0c2b7c4fc3549bb2c44777093fa6588c9da451e1 8220575: Correctly format test URI's that contain a retrieved IPv6 address Oct 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 21, 2021

Webrevs

Loading

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

URIBuilder.java was already added with JDK-8225425. Your backport looks good to me.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8220575: Correctly format test URI's that contain a retrieved IPv6 address

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 25c33bc: 8239422: [TESTBUG] compiler/c1/TestPrintIRDuringConstruction.java failed when C1 is disabled
  • 00255bd: 8263068: Rename safefetch.hpp to safefetch.inline.hpp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added the ready label Oct 21, 2021
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Oct 25, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

Going to push as commit 5495b79.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 25c33bc: 8239422: [TESTBUG] compiler/c1/TestPrintIRDuringConstruction.java failed when C1 is disabled
  • 00255bd: 8263068: Rename safefetch.hpp to safefetch.inline.hpp

Your commit was automatically rebased without conflicts.

Loading

@openjdk openjdk bot closed this Oct 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

@RealCLanger Pushed as commit 5495b79.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@RealCLanger RealCLanger deleted the RealCLanger-backport-0c2b7c4f branch Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants