Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8226514: Replace wildcard address with loopback or local host in tests - part 17 #548

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 21, 2021

Backport of JDK-8226514.
Needed some trivial resolving (Copyright year) and some minor modifications, seen in the 2nd commit.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8226514: Replace wildcard address with loopback or local host in tests - part 17

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/548/head:pull/548
$ git checkout pull/548

Update a local copy of the PR:
$ git checkout pull/548
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/548/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 548

View PR using the GUI difftool:
$ git pr show -t 548

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/548.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 21, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into pr/547 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 2ad9f11d7763051fc8c2ed9175ddc9f4b329c636 8226514: Replace wildcard address with loopback or local host in tests - part 17 Oct 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr labels Oct 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 21, 2021

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Looks okay. I wish we had better tool support for comparing trivially changed fixes.

Cheers, Thomas

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/547 to master Oct 25, 2021
@openjdk-notifier
Copy link

@openjdk-notifier openjdk-notifier bot commented Oct 25, 2021

The dependent pull request has now been integrated, and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout RealCLanger-backport-0c2b7c4f
git fetch https://git.openjdk.java.net/jdk11u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8226514: Replace wildcard address with loopback or local host in tests - part 17

Improve test stabilty by getting rid of the wildcard address whenever possible.

Reviewed-by: stuefe, mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 25, 2021
@RealCLanger RealCLanger force-pushed the RealCLanger-backport-2ad9f11d branch from 69cb331 to 1dfc3b8 Compare Oct 25, 2021
@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Oct 25, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

Going to push as commit e216ee6.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 80e371c: 8233567: [TESTBUG] FocusSubRequestTest.java fails on macos
  • cfb1bd2: 8233555: [TESTBUG] JRadioButton tests failing on MacoS
  • 73fd4da: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 25, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

@RealCLanger Pushed as commit e216ee6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-2ad9f11d branch Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
3 participants