Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233555: [TESTBUG] JRadioButton tests failing on MacoS #549

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Oct 21, 2021

Backport of JDK-8233555. Enables 3 tests by removing them from ProblemList.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233555: [TESTBUG] JRadioButton tests failing on MacoS

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/549/head:pull/549
$ git checkout pull/549

Update a local copy of the PR:
$ git checkout pull/549
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/549/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 549

View PR using the GUI difftool:
$ git pr show -t 549

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/549.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 21, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 227f99d394571331ffa40b0b6b9d9d61c90635dd 8233555: [TESTBUG] JRadioButton tests failing on MacoS Oct 21, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 21, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233555: [TESTBUG] JRadioButton tests failing on MacoS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Oct 21, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 21, 2021

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

@TheRealMDoerr TheRealMDoerr commented Oct 25, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

Going to push as commit cfb1bd2.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 73fd4da: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS
  • 5495b79: 8220575: Correctly format test URI's that contain a retrieved IPv6 address

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 25, 2021
@openjdk openjdk bot added the integrated label Oct 25, 2021
@TheRealMDoerr TheRealMDoerr deleted the 8233555_swing_test branch Oct 25, 2021
@openjdk openjdk bot removed ready rfr labels Oct 25, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 25, 2021

@TheRealMDoerr Pushed as commit cfb1bd2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant