Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8233567: [TESTBUG] FocusSubRequestTest.java fails on macos #551

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Oct 21, 2021

Clean backport of JDK-8233567.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8233567: [TESTBUG] FocusSubRequestTest.java fails on macos

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/551/head:pull/551
$ git checkout pull/551

Update a local copy of the PR:
$ git checkout pull/551
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/551/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 551

View PR using the GUI difftool:
$ git pr show -t 551

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/551.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b90ad76d6b8a4b2096ae096252dead9626d7e09b 8233567: [TESTBUG] FocusSubRequestTest.java fails on macos Oct 21, 2021
@openjdk
Copy link

openjdk bot commented Oct 21, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 21, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8233567: [TESTBUG] FocusSubRequestTest.java fails on macos

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 21, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2021

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2021

Going to push as commit 80e371c.
Since your change was applied there have been 3 commits pushed to the master branch:

  • cfb1bd2: 8233555: [TESTBUG] JRadioButton tests failing on MacoS
  • 73fd4da: 8270116: Expand ButtonGroupLayoutTraversalTest.java to run in all LaFs, including Aqua on macOS
  • 5495b79: 8220575: Correctly format test URI's that contain a retrieved IPv6 address

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 25, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2021
@openjdk
Copy link

openjdk bot commented Oct 25, 2021

@TheRealMDoerr Pushed as commit 80e371c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant