Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275713: TestDockerMemoryMetrics test fails on recent runc #552

Closed

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Oct 21, 2021

Please review this test bug which only affects JDK less than 15. Kernel memory tracking is deprecated. In head I'll follow up with a bug that'll remove that code entirely as it's pretty useless at this point.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8275713: TestDockerMemoryMetrics test fails on recent runc

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/552/head:pull/552
$ git checkout pull/552

Update a local copy of the PR:
$ git checkout pull/552
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/552/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 552

View PR using the GUI difftool:
$ git pr show -t 552

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/552.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 21, 2021

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 21, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 21, 2021

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Oct 21, 2021

https://bugs.openjdk.java.net/browse/JDK-8275735 is the issue logged for mainline JDK.

@openjdk
Copy link

openjdk bot commented Oct 22, 2021

@jerboaa This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8275713: TestDockerMemoryMetrics test fails on recent runc

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 22, 2021
@jerboaa
Copy link
Contributor Author

jerboaa commented Oct 28, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2021

Going to push as commit fd22289.
Since your change was applied there have been 40 commits pushed to the master branch:

  • 43f27be: 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3
  • 9cc6616: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST
  • 8a9cda2: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream
  • 352672f: 8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows
  • 243fd30: 8198623: java/awt/KeyboardFocusmanager/TypeAhead/EnqueueWithDialogButtonTest/EnqueueWithDialogButtonTest.java fails on mac
  • d8941d4: 8246807: Incorrect copyright header in TimeZoneDatePermissionCheck.sh
  • 7acc631: 8131745: java/lang/management/ThreadMXBean/AllThreadIds.java still fails intermittently
  • 3fb7528: 8274407: (tz) Update Timezone Data to 2021c
  • 7c3f2d5: Merge
  • 71f2c75: 8267086: ArrayIndexOutOfBoundsException in java.security.KeyFactory.generatePublic
  • ... and 30 more: https://git.openjdk.java.net/jdk11u-dev/compare/25c33bc9a571d81d1a2efaa74b5fe585ba1d334b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2021
@openjdk
Copy link

openjdk bot commented Oct 28, 2021

@jerboaa Pushed as commit fd22289.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants