Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8131745: java/lang/management/ThreadMXBean/AllThreadIds.java still fails intermittently #556

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 25, 2021

Backport of JDK-8131745: java/lang/management/ThreadMXBean/AllThreadIds.java still fails intermittently

Merely clean, I only had to resolve ProblemList.txt.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8131745: java/lang/management/ThreadMXBean/AllThreadIds.java still fails intermittently

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/556/head:pull/556
$ git checkout pull/556

Update a local copy of the PR:
$ git checkout pull/556
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/556/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 556

View PR using the GUI difftool:
$ git pr show -t 556

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/556.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ea9aeda5ee89c02add8c69c1045659dd9eac5154 8131745: java/lang/management/ThreadMXBean/AllThreadIds.java still fails intermittently Oct 25, 2021
@openjdk
Copy link

openjdk bot commented Oct 25, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 25, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 25, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8131745: java/lang/management/ThreadMXBean/AllThreadIds.java still fails intermittently

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 25, 2021
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 26, 2021

Going to push as commit 7acc631.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2021
@openjdk
Copy link

openjdk bot commented Oct 26, 2021

@RealCLanger Pushed as commit 7acc631.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-ea9aeda5 branch October 26, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants