Skip to content

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 25, 2021

Backport of JDK-8219986


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8219986: Change to Xcode 10.1 for building on Macosx at Oracle

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/557/head:pull/557
$ git checkout pull/557

Update a local copy of the PR:
$ git checkout pull/557
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/557/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 557

View PR using the GUI difftool:
$ git pr show -t 557

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/557.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 53adab6857492905246c024b80a27bb989a996e3 8219986: Change to Xcode 10.1 for building on Macosx at Oracle Oct 25, 2021
@openjdk
Copy link

openjdk bot commented Oct 25, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Oct 25, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2021

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Oct 26, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8219986: Change to Xcode 10.1 for building on Macosx at Oracle

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 3fb7528: 8274407: (tz) Update Timezone Data to 2021c

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 26, 2021
@GoeLin
Copy link
Member

GoeLin commented Oct 29, 2021

I guess the Pre-submit test failure is unrelated?

@RealCLanger
Copy link
Contributor Author

I guess the Pre-submit test failure is unrelated?

Definitely. This change doesn't modify the build. And gc/TestMemoryInitializationWithCMS.java in x86 32 looks like something intermittent...

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 29, 2021

Going to push as commit d2fb307.
Since your change was applied there have been 9 commits pushed to the master branch:

  • fd22289: 8275713: TestDockerMemoryMetrics test fails on recent runc
  • 43f27be: 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3
  • 9cc6616: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST
  • 8a9cda2: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream
  • 352672f: 8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows
  • 243fd30: 8198623: java/awt/KeyboardFocusmanager/TypeAhead/EnqueueWithDialogButtonTest/EnqueueWithDialogButtonTest.java fails on mac
  • d8941d4: 8246807: Incorrect copyright header in TimeZoneDatePermissionCheck.sh
  • 7acc631: 8131745: java/lang/management/ThreadMXBean/AllThreadIds.java still fails intermittently
  • 3fb7528: 8274407: (tz) Update Timezone Data to 2021c

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2021
@openjdk
Copy link

openjdk bot commented Oct 29, 2021

@RealCLanger Pushed as commit d2fb307.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the backport-8219986 branch October 29, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants