Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8199529: javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java fails on windows #559

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 26, 2021

Backport of JDK-8199529. Applies clean, only problem list needed resolving.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8199529: javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java fails on windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/559/head:pull/559
$ git checkout pull/559

Update a local copy of the PR:
$ git checkout pull/559
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/559/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 559

View PR using the GUI difftool:
$ git pr show -t 559

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/559.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1ce6ec6a28ab530f04ebbed04f92f2f9bd9a7a6f 8199529: javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java fails on windows Oct 26, 2021
@openjdk
Copy link

openjdk bot commented Oct 26, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 26, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8199529: javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java fails on windows

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 243fd30: 8198623: java/awt/KeyboardFocusmanager/TypeAhead/EnqueueWithDialogButtonTest/EnqueueWithDialogButtonTest.java fails on mac
  • d8941d4: 8246807: Incorrect copyright header in TimeZoneDatePermissionCheck.sh
  • 7acc631: 8131745: java/lang/management/ThreadMXBean/AllThreadIds.java still fails intermittently
  • 3fb7528: 8274407: (tz) Update Timezone Data to 2021c

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2021

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, if needed.

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 29, 2021

Going to push as commit ff65591.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 4a99728: 8249195: Change to Xcode 11.3.1 for building on Macos at Oracle
  • 1c90fe0: 8256202: Some tweaks for jarsigner tests PosixPermissionsTest and SymLinkTest
  • d2fb307: 8219986: Change to Xcode 10.1 for building on Macosx at Oracle
  • fd22289: 8275713: TestDockerMemoryMetrics test fails on recent runc
  • 43f27be: 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3
  • 9cc6616: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST
  • 8a9cda2: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream
  • 352672f: 8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows
  • 243fd30: 8198623: java/awt/KeyboardFocusmanager/TypeAhead/EnqueueWithDialogButtonTest/EnqueueWithDialogButtonTest.java fails on mac
  • d8941d4: 8246807: Incorrect copyright header in TimeZoneDatePermissionCheck.sh
  • ... and 2 more: https://git.openjdk.java.net/jdk11u-dev/compare/7c3f2d5a53d69e39d02f5de0e6fd07bbe88ffceb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2021
@openjdk
Copy link

openjdk bot commented Oct 29, 2021

@RealCLanger Pushed as commit ff65591.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-1ce6ec6a branch Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants