Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows #561

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 26, 2021

I backport this for parity with 11.0.14-oracle.

In 11, the test is problem listed with bug 8192930, but that is a duplicate
of 8197811, so clearing the ProblemList is fine.

The patch for the test had to be adapted because
in head it uses Platform.java instead of OSInfo.java.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/561/head:pull/561
$ git checkout pull/561

Update a local copy of the PR:
$ git checkout pull/561
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/561/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 561

View PR using the GUI difftool:
$ git pr show -t 561

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/561.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 26, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d1c8c9eabbc420df19b07efc5e8adc85556079fb 8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows Oct 26, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Oct 26, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 26, 2021

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

LGTM. Thanks for backporting.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 26, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8197811: Test java/awt/Choice/PopupPosTest/PopupPosTest.java fails on Windows

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Oct 26, 2021
@GoeLin
Copy link
Member Author

@GoeLin GoeLin commented Oct 27, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

Going to push as commit 352672f.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 243fd30: 8198623: java/awt/KeyboardFocusmanager/TypeAhead/EnqueueWithDialogButtonTest/EnqueueWithDialogButtonTest.java fails on mac
  • d8941d4: 8246807: Incorrect copyright header in TimeZoneDatePermissionCheck.sh
  • 7acc631: 8131745: java/lang/management/ThreadMXBean/AllThreadIds.java still fails intermittently

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 27, 2021

@GoeLin Pushed as commit 352672f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8197811 branch Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants