Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3 #563

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 27, 2021

I think we should have this fix in 11, too.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/563/head:pull/563
$ git checkout pull/563

Update a local copy of the PR:
$ git checkout pull/563
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/563/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 563

View PR using the GUI difftool:
$ git pr show -t 563

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/563.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2021

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8d3de4b1bdb5dc13bb7724596dc2123ba05bbb81 8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3 Oct 27, 2021
@openjdk
Copy link

openjdk bot commented Oct 27, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 27, 2021

@GoeLin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8262844: (fs) FileStore.supportsFileAttributeView might return false negative in case of ext3

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 27, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2021

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 28, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2021

Going to push as commit 43f27be.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 9cc6616: 8274779: HttpURLConnection: HttpClient and HttpsClient incorrectly check request method when set to POST
  • 8a9cda2: 8190753: (zipfs): Accessing a large entry (> 2^31 bytes) leads to a negative initial size for ByteArrayOutputStream

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 28, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2021
@openjdk
Copy link

openjdk bot commented Oct 28, 2021

@GoeLin Pushed as commit 43f27be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8262844 branch October 28, 2021 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant