Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8256202: Some tweaks for jarsigner tests PosixPermissionsTest and SymLinkTest #564

Closed

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Oct 28, 2021

Backport of JDK-8256202. Changes in SymLinkTest.java apply cleanly.
Hunks in PosixPermissionsTest.java had to be integrated manually because the test is different in 11u (see backport of the related issues JDK-8218021 and JDK-8250968). This backport only contains cleanup in this file. Other hunks are not applicable.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8256202: Some tweaks for jarsigner tests PosixPermissionsTest and SymLinkTest

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/564/head:pull/564
$ git checkout pull/564

Update a local copy of the PR:
$ git checkout pull/564
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/564/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 564

View PR using the GUI difftool:
$ git pr show -t 564

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/564.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2021

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1e9a432d59fa3fb3d038c83c88fd7eeb3052960c 8256202: Some tweaks for jarsigner tests PosixPermissionsTest and SymLinkTest Oct 28, 2021
@openjdk
Copy link

openjdk bot commented Oct 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 28, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 28, 2021

@TheRealMDoerr This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8256202: Some tweaks for jarsigner tests PosixPermissionsTest and SymLinkTest

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 28, 2021
@TheRealMDoerr
Copy link
Contributor Author

Thanks for the review and the approval!
/integrate

@openjdk
Copy link

openjdk bot commented Oct 29, 2021

Going to push as commit 1c90fe0.
Since your change was applied there has been 1 commit pushed to the master branch:

  • d2fb307: 8219986: Change to Xcode 10.1 for building on Macosx at Oracle

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 29, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 29, 2021
@openjdk
Copy link

openjdk bot commented Oct 29, 2021

@TheRealMDoerr Pushed as commit 1c90fe0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the 8256202_jarsigner branch October 29, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants