Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac #565

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 28, 2021

Backport of JDK-7151826


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/565/head:pull/565
$ git checkout pull/565

Update a local copy of the PR:
$ git checkout pull/565
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/565/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 565

View PR using the GUI difftool:
$ git pr show -t 565

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/565.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 28, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4d9f20734791b30000547e90171191ae690ed245 7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac Oct 28, 2021
@openjdk
Copy link

openjdk bot commented Oct 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 28, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

7151826: [TEST_BUG] [macosx] The test javax/swing/JPopupMenu/4966112/bug4966112.java not for mac

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 28, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 30, 2021

Going to push as commit 36e54fb.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 363ab5f: 8233635: [TESTBUG] ProgressMonitorEscapeKeyPress.java fails on macos
  • ff65591: 8199529: javax/swing/text/Utilities/8142966/SwingFontMetricsTest.java fails on windows
  • 4a99728: 8249195: Change to Xcode 11.3.1 for building on Macos at Oracle
  • 1c90fe0: 8256202: Some tweaks for jarsigner tests PosixPermissionsTest and SymLinkTest
  • d2fb307: 8219986: Change to Xcode 10.1 for building on Macosx at Oracle

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 30, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 30, 2021
@openjdk
Copy link

openjdk bot commented Oct 30, 2021

@RealCLanger Pushed as commit 36e54fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the RealCLanger-backport-4d9f2073 branch October 30, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant