Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX #569

Closed

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Oct 31, 2021

Hi all,

this pull request contains a backport of JDK-8015602 from the openjdk/jdk repository.

The commit being backported was authored by Sergey Bylokhov on 27 Oct 2020 and was reviewed by Prasanta Sadhukhan and Pankaj Bansal.

I ran javax/swing/SpringLayout/4726194/bug4726194.java on my MacOS and it passes. It is, however, still excluded. One would have to backport JDK-8254976 to enable it.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk11u-dev pull/569/head:pull/569
$ git checkout pull/569

Update a local copy of the PR:
$ git checkout pull/569
$ git pull https://git.openjdk.java.net/jdk11u-dev pull/569/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 569

View PR using the GUI difftool:
$ git pr show -t 569

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk11u-dev/pull/569.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 31, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport dc85a3fe816a74cca4f427bb8f24dfa9717b4c01 8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX Oct 31, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 31, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Oct 31, 2021

@RealCLanger This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8015602: [macosx] Test javax/swing/SpringLayout/4726194/bug4726194.java fails on MacOSX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 31, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Nov 5, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

Going to push as commit a855b6f.
Since your change was applied there have been 3 commits pushed to the master branch:

  • fe7ee62: 8223141: Change (count) suffix _ct into _cnt.
  • 1ae1563: 8267304: Bump global JTReg memory limit to 768m
  • ad40b61: 8235784: java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java fails due to timeout with fastdebug bits

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Nov 5, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 5, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Nov 5, 2021

@RealCLanger Pushed as commit a855b6f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant